[MNG-7417] Several classes do not set properties properly for building requests #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfscholte
reviewed
Jun 21, 2020
...ider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java
Outdated
Show resolved
Hide resolved
slachiewicz
force-pushed
the
MNG-5982
branch
2 times, most recently
from
b916126
to
80f6adb
Compare
|
@slachiewicz This is the actual problem: https://issues.apache.org/jira/browse/MNG-7417 @slachiewicz If you don't mind I will pick this one up. |
michael-o
requested changes
Feb 20, 2022
...ider/src/main/java/org/apache/maven/repository/internal/DefaultArtifactDescriptorReader.java
Outdated
Show resolved
Hide resolved
michael-o
pushed a commit
to slachiewicz/maven
that referenced
this pull request
Feb 20, 2022
…g requests This closes apache#306
michael-o
reviewed
Feb 20, 2022
maven-compat/src/main/java/org/apache/maven/project/DefaultMavenProjectBuilder.java
Outdated
Show resolved
Hide resolved
…g requests This closes apache#306
michael-o
changed the title
michael-o
approved these changes
Feb 20, 2022
There was a problem hiding this comment.
@slachiewicz I have reverted the block in Maven Compat because we should touch this module as little as possible. The rest is just fine.
If I don't hear any objections I will merge this into master and 3.8.x tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should pass also user properties when building a Model for a pom.
Locally tests passed for https://issues.apache.org/jira/browse/MNG-5982
Is this a good way to fix the problem? How ITs should look?